Change instances of Teacher to Instructor#4
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to implement Issue #1 by renaming the educator-facing terminology from “Teacher” to “Instructor” across the app (UI/docs/implementation).
Changes:
- Renames the dashboard component to
InstructorPageand updates its role-guard to check forrole === "instructor". - Updates routing to serve the dashboard at
/instructorand updates README wording/env var naming accordingly. - Includes regenerated build output under
dist/(but it still contains “Teacher” strings) and an unintended Vite artifact undernode_modules/.
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/InstructorPage.jsx | Renames page component + changes role check to instructor. |
| src/App.jsx | Switches dashboard route/import from teacher to instructor. |
| README.md | Updates wording and env var name to “instructor”. |
| node_modules/.vite/deps/_metadata.json | Generated Vite artifact (should not be committed). |
| dist/index.html | Updates built bundle reference. |
| dist/assets/index-HXjiAoNO.js | Built bundle; still contains “Teacher” role/UI strings and /teacher navigation. |
Comments suppressed due to low confidence (1)
src/pages/InstructorPage.jsx:52
- This guard checks for role === "instructor", but RoleSelector currently sets role="teacher" and navigates to "/teacher" (src/pages/RoleSelector.jsx:25-27). As-is, even a valid login will immediately redirect away from the dashboard.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
23
to
25
| <Route path="/" element={<RoleSelector />} /> | ||
| <Route path="/teacher" element={<TeacherPage />} /> | ||
| <Route path="/instructor" element={<InstructorPage />} /> | ||
| <Route path="/student" element={<StudentPage />} /> |
Comment on lines
140
to
152
| @@ -148,7 +148,7 @@ VITE_FIREBASE_STORAGE_BUCKET=your_project.firebasestorage.app | |||
| VITE_FIREBASE_MESSAGING_SENDER_ID=your_sender_id | |||
| VITE_FIREBASE_APP_ID=your_app_id | |||
|
|
|||
| VITE_TEACHER_PASSWORD=your_password_here | |||
| VITE_INSTRUCTOR_PASSWORD=your_password_here | |||
| ``` | |||
Comment on lines
7
to
12
| "react": { | ||
| "src": "../../react/index.js", | ||
| "file": "react.js", | ||
| "fileHash": "4c5b97b1", | ||
| "fileHash": "62626146", | ||
| "needsInterop": true | ||
| }, |
jody
added a commit
that referenced
this pull request
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1